JdbcAggregateTemplate honors columns specified in query #1967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schauder
force-pushed
the
issue/1803-projection
branch
from
155004e to
cbde1e7
Compare
mp911de
requested changes
Jan 16, 2025
spring-data-jdbc/src/main/java/org/springframework/data/jdbc/core/convert/SqlGenerator.java
Show resolved
Hide resolved
mp911de
force-pushed
the
main
branch
2 times, most recently
from
571fd96 to
1f2e694
Compare
schauder
force-pushed
the
issue/1803-projection
branch
from
2326e23 to
09d2d28
Compare
If no columns are given, all columns are selected by default. If columns are specified, only these are selected. Joins normally triggered by columns from 1:1 relationships are not implemented, and the corresponding columns don't get loaded and can't be specified in a query. Limiting columns is not supported for single query loading. Closes #1803
Extract method. Extend tests. Introduce empty Query object to avoid nullability.
Resolve mapped property paths to aggregate paths. Add tests.
mp911de
force-pushed
the
issue/1803-projection
branch
from
09d2d28 to
80c113a
Compare
When fields from referenced entities got requested, ther intermediate necessary joins were not included.
mp911de
added
type: bug
mp911de
pushed a commit
that referenced
this pull request
Jun 13, 2025
If no columns are given, all columns are selected by default. If columns are specified, only these are selected. Joins normally triggered by columns from 1:1 relationships are not implemented, and the corresponding columns don't get loaded and can't be specified in a query. Limiting columns is not supported for single query loading. Closes #1803 Original pull request: #1967
mp911de
pushed a commit
that referenced
this pull request
Jun 13, 2025
If no columns are given, all columns are selected by default. If columns are specified, only these are selected. Joins normally triggered by columns from 1:1 relationships are not implemented, and the corresponding columns don't get loaded and can't be specified in a query. Limiting columns is not supported for single query loading. Closes #1803 Original pull request: #1967
|
That's merged, polished, and backported now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no columns are given, all columns are selected by default.
If columns are specified, only these are selected.
Joins normally triggered by columns from 1:1 relationships are not implemented, and the corresponding columns don't get loaded and can't be specified in a query.
Limiting columns is not supported for single query loading.
Closes #1803